Alice B. - Earth #27
Open
Alice B. - Earth #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 6, 2021 16:05
CheezItMan
reviewed
Jan 16, 2021
Comment on lines
+22
to
+28
| const formatLine = FIELDS.map((field) => { | ||
| if (field.key) { | ||
| return line[field.key]; | ||
| } else { | ||
| return field; | ||
| } | ||
| }).join(' '); |
There was a problem hiding this comment.
Everything in here should have a key as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
Describe the relationships between the components on a high-level: which components were siblings? Which components were nested within each other? | Game was nested in the app, the other components were nested inside Game and were all siblings of each other.
How did this project differ from in-class examples? | All three sibling components needed access to some of state that was inside Game.
How was this project similar to in-class examples? | Using state and props are similar.